[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070706180241.GB4457@austin.ibm.com>
Date: Fri, 6 Jul 2007 13:02:41 -0500
From: linas@...tin.ibm.com (Linas Vepstas)
To: Masakazu Mokuno <mokuno@...sony.co.jp>
Cc: Geoff Levand <geoffrey.levand@...sony.com>, netdev@...r.kernel.org,
cbe-oss-dev@...abs.org, Jeff Garzik <jeff@...zik.org>
Subject: Re: [Cbe-oss-dev] [PATCH] ps3: gigabit ethernet driver for PS3, take3
On Thu, Jul 05, 2007 at 11:47:20AM -0500, jschopp wrote:
>
> This is the third submission of the network driver for PS3.
> The differences from the previous one are:
I notice that this mostly a cut-n-paste of a very old version
of the spidernet device driver. Please note that the old
spidernet had absolutely disasterous performance for transmit;
it also had a variety of crazy hangs and lockups under
high-stress conditions; or NFS operation, or certain back-to-back
tcp usage scenarios. A few dozen bugfixes went in since
the time that the gelic snapshot was taken.
Wouldn't it be better to just add the hypervisor bits-n-pieces
to spidernet? That way, you get not only the various fixes, but
also the benefit of fairly regular testing...
--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists