netdev - Re: [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in cxgb3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1183889330.3771.0.camel@johannes.berg>
Date:	Sun, 08 Jul 2007 12:08:49 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] CXGB3: Replace kcalloc(1,...) with kmalloc() in
	cxgb3_offload.c.

On Sun, 2007-07-08 at 05:39 -0400, Robert P. J. Day wrote:

> -	t = kcalloc(1, sizeof(*t), GFP_KERNEL);
> +	t = kcalloc(sizeof(*t), GFP_KERNEL);
               ^
I don't think that's going to work, and shouldn't it probably use
kzalloc instead of kmalloc (as you wrote in subject)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)