lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 10 Jul 2007 14:49:30 +0530
From:	Satyam Sharma <>
To:	Linux Kernel Mailing List <>
Cc:	Matt Mackall <>,
	Keiichi Kii <>,
	Satyam Sharma <>,
	Netdev <>,
	Joel Becker <>,
	Stephen Hemminger <>,
	Andrew Morton <>,
	David Miller <>
Subject: [PATCH v2 -mm 2/9] netconsole: Remove bogus check

From: Satyam Sharma <>

[2/9] netconsole: Remove bogus check

The (! check in write_msg() is bogus (always false), because: is set by netpoll_setup(), which is called by the target init
code in init_netconsole() _before_ register_console() => write_msg() cannot
be triggered unless netpoll_setup() returns with success. And that will not
happen if netpoll_setup() failed to set Also cannot go from
under us while netconsole is loaded. This is because netpoll_setup() grabs
a reference for us on that dev. So let's remove the pointless check.

Signed-off-by: Satyam Sharma <>
Cc: Keiichi Kii <>


 drivers/net/netconsole.c |    3 ---
 1 file changed, 3 deletions(-)


diff -ruNp a/drivers/net/netconsole.c b/drivers/net/netconsole.c
--- a/drivers/net/netconsole.c	2007-07-10 05:53:42.000000000 +0530
+++ b/drivers/net/netconsole.c	2007-07-10 05:55:00.000000000 +0530
@@ -67,9 +67,6 @@ static void write_msg(struct console *co
 	int frag, left;
 	unsigned long flags;
-	if (!
-		return;
 	for (left = len; left;) {
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists