lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Jul 2007 14:49:30 +0530 From: Satyam Sharma <ssatyam@....iitk.ac.in> To: Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Cc: Matt Mackall <mpm@...enic.com>, Keiichi Kii <k-keiichi@...jp.nec.com>, Satyam Sharma <ssatyam@....iitk.ac.in>, Netdev <netdev@...r.kernel.org>, Joel Becker <joel.becker@...cle.com>, Stephen Hemminger <shemminger@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, David Miller <davem@...emloft.net> Subject: [PATCH v2 -mm 2/9] netconsole: Remove bogus check From: Satyam Sharma <ssatyam@....iitk.ac.in> [2/9] netconsole: Remove bogus check The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is set by netpoll_setup(), which is called by the target init code in init_netconsole() _before_ register_console() => write_msg() cannot be triggered unless netpoll_setup() returns with success. And that will not happen if netpoll_setup() failed to set np.dev. Also np.dev cannot go from under us while netconsole is loaded. This is because netpoll_setup() grabs a reference for us on that dev. So let's remove the pointless check. Signed-off-by: Satyam Sharma <ssatyam@....iitk.ac.in> Cc: Keiichi Kii <k-keiichi@...jp.nec.com> --- drivers/net/netconsole.c | 3 --- 1 file changed, 3 deletions(-) --- diff -ruNp a/drivers/net/netconsole.c b/drivers/net/netconsole.c --- a/drivers/net/netconsole.c 2007-07-10 05:53:42.000000000 +0530 +++ b/drivers/net/netconsole.c 2007-07-10 05:55:00.000000000 +0530 @@ -67,9 +67,6 @@ static void write_msg(struct console *co int frag, left; unsigned long flags; - if (!np.dev) - return; - local_irq_save(flags); for (left = len; left;) { - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists