lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 10 Jul 2007 04:05:24 -0500
From:	Matt Mackall <>
To:	Satyam Sharma <>
Cc:	Linux Kernel Mailing List <>,
	Keiichi Kii <>,
	Netdev <>,
	Joel Becker <>,
	Stephen Hemminger <>,
	Andrew Morton <>,
	David Miller <>
Subject: Re: [PATCH v2 -mm 2/9] netconsole: Remove bogus check

On Tue, Jul 10, 2007 at 02:49:30PM +0530, Satyam Sharma wrote:
> From: Satyam Sharma <>
> [2/9] netconsole: Remove bogus check
> The (! check in write_msg() is bogus (always false), because:
> is set by netpoll_setup(), which is called by the target init
> code in init_netconsole() _before_ register_console() => write_msg() cannot
> be triggered unless netpoll_setup() returns with success. And that will not
> happen if netpoll_setup() failed to set Also cannot go from
> under us while netconsole is loaded. This is because netpoll_setup() grabs
> a reference for us on that dev. So let's remove the pointless check.
> Signed-off-by: Satyam Sharma <>
> Cc: Keiichi Kii <>

Acked-by: Matt Mackall <>

Mathematics is the supreme nostalgia of our time.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists