lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Jul 2007 11:23:15 +0100 From: "Duane Griffin" <duaneg@...da.com> To: "Satyam Sharma" <ssatyam@....iitk.ac.in> Cc: "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>, "Matt Mackall" <mpm@...enic.com>, "Keiichi Kii" <k-keiichi@...jp.nec.com>, Netdev <netdev@...r.kernel.org>, "Joel Becker" <joel.becker@...cle.com>, "Stephen Hemminger" <shemminger@...ux-foundation.org>, "Andrew Morton" <akpm@...ux-foundation.org>, "David Miller" <davem@...emloft.net> Subject: Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets On 10/07/07, Satyam Sharma <ssatyam@....iitk.ac.in> wrote: > + /* Avoid taking lock and disabling interrupts unnecessarily */ > + if (unlikely(list_empty(&target_list))) > + return; Is the unlikely a good idea here? Not having any targets may be unusual but it isn't ridiculous. It might even be a sensible default for distros. My (very limited) understanding of unlikely is that it could impose a very large penalty in that case and would make a very marginal difference at best in the common case. Cheers, Duane. -- "I never could learn to drink that blood and call it wine" - Bob Dylan - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists