lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 10 Jul 2007 11:23:15 +0100
From:	"Duane Griffin" <>
To:	"Satyam Sharma" <>
Cc:	"Linux Kernel Mailing List" <>,
	"Matt Mackall" <>,
	"Keiichi Kii" <>,
	Netdev <>,
	"Joel Becker" <>,
	"Stephen Hemminger" <>,
	"Andrew Morton" <>,
	"David Miller" <>
Subject: Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets

On 10/07/07, Satyam Sharma <> wrote:
> +       /* Avoid taking lock and disabling interrupts unnecessarily */
> +       if (unlikely(list_empty(&target_list)))
> +               return;

Is the unlikely a good idea here? Not having any targets may be
unusual but it isn't ridiculous. It might even be a sensible default
for distros. My (very limited) understanding of unlikely is that it
could impose a very large penalty in that case and would make a very
marginal difference at best in the common case.


"I never could learn to drink that blood and call it wine" - Bob Dylan
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists