netdev - Fw: iproute2 showing wrong number of bytes on 64bit architectures.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070710085640.128311d1@freepuppy.rosehill.hemminger.net>
Date:	Tue, 10 Jul 2007 08:56:40 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	netdev@...r.kernel.org
Subject: Fw: iproute2 showing wrong number of bytes on 64bit architectures.

Looks like net_device_stats should have always used u32?
Too late to change it now.

Begin forwarded message:

Date: Tue, 10 Jul 2007 13:58:51 +0200
From: Andreas Henriksson <andreas@...al.se>
To: netdev@...r.kernel.org
Cc: 199054@...s.debian.org
Subject: iproute2 showing wrong number of bytes on 64bit architectures.

Hello!

While investigating the problems reported in Debian bug #199054
(http://bugs.debian.org/199054), stating that the RX/TX bytes differ between
ifconfig and ip(route2) I came across this:

include/linux/if_link.h (used in kernel and iproute2 source):
/* The struct should be in sync with struct net_device_stats */
struct rtnl_link_stats
{
	__u32 ...;
	__u32 ...;
	__u32 ...;
	__u32 ...;
...

include/linux/netdevice.h:
struct net_device_stats
{
	unsigned long   ...;
	unsigned long   ...;
	unsigned long   ...;
	unsigned long   ...;
	unsigned long   ...;
....

This will be a problem when unsigned long isn't 32bits, but I guess the
rtnetlink message size is static for good reason. 
Can someone please advise on how to fix this?

-- 
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html