lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4693B2F8.3070702@garzik.org> Date: Tue, 10 Jul 2007 12:25:28 -0400 From: Jeff Garzik <jeff@...zik.org> To: Linas Vepstas <linas@...tin.ibm.com> CC: netdev@...r.kernel.org, cbe-oss-dev@...abs.org, Kou Ishizaki <kou.ishizaki@...hiba.co.jp> Subject: Re: [PATCH] spidernet: improve interrupt handling Linas Vepstas wrote: > From: Ishizaki Kou <kou.ishizaki@...hiba.co.jp> > > We intend this patch to improve spidernet interrupt handling to be > more strict. We had following problem and this patch solves it. > > -when CONFIG_DEBUG_SHIRQ=y, request_irq() calls handler(). > -when spider_net_open() is called, it calls request_irq() which calls > spider_net_interrupt(). > -if some specific interrupt bit is set at this timing, it calls > netif_rx_schedule() and spider_net_poll() is scheduled. > -spider_net_open() calls netif_poll_enable() which clears the bit > __LINK_STATE_RX_SCHED. > -when spider_net_poll() is called, it calls netif_rx_complete() which > causes BUG_ON() because __LINK_STATE_RX_SCHED is not set. > > Signed-off-by: Kou Ishizaki <kou.ishizaki@...hiba.co.jp> > Signed-off-by: Linas Vepstas <linas@...tin.ibm.com> > > ---- > Jeff, please apply for 2.6.23 > > Linas. > > drivers/net/spider_net.c | 59 +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 45 insertions(+), 14 deletions(-) > applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists