netdev - Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4693CC97.4030207@garzik.org>
Date:	Tue, 10 Jul 2007 14:14:47 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Masakazu Mokuno <mokuno@...sony.co.jp>
CC:	netdev@...r.kernel.org, cbe-oss-dev@...abs.org
Subject: Re: [PATCH] ps3: gigabit ethernet driver for PS3, take3

Masakazu Mokuno wrote:
> Hi, 
> 
> This is the third submission of the network driver for PS3.
> The differences from the previous one are:
> 
>   - renamed source file names so that their prefix can match
>     with the module name
>   - added cbe-oss-dev@...abs.org line for MAINTAINER file
>   - changed some in copyright comments
>   
> If there are no more comments, please apply for 2.6.23. 
> 
> Thank you
> 
> --
> Subject: PS3: Ethernet driver
> 
> From: Masakazu Mokuno <mokuno@...sony.co.jp>
> 
> Add Gigabit Ethernet support for the PS3 game console.  The module will
> be called ps3_gelic.
> 
> CC: Geoff Levand <geoffrey.levand@...sony.com>
> Signed-off-by: Masakazu Mokuno <mokuno@...sony.co.jp>
> ---
>  MAINTAINERS                 |    7 
>  drivers/net/Kconfig         |   10 
>  drivers/net/Makefile        |    2 
>  drivers/net/ps3_gelic_net.c | 1576 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/ps3_gelic_net.h |  239 ++++++
>  5 files changed, 1834 insertions(+)

applied

I request that you fix the NETDEV_TX_LOCKED return value on error in 
->hard_start_xmit(), which appears to be an incorrect return value for 
that condition, for your driver

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html