netdev - Re: [PATCH] Virtual ethernet device (v2.1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070711094430.GA9672@2ka.mipt.ru>
Date:	Wed, 11 Jul 2007 13:44:30 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Pavel Emelianov <xemul@...nvz.org>
Cc:	David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Daniel Lezcano <dlezcano@...ibm.com>,
	Ben Greear <greearb@...delatech.com>, devel@...nvz.org,
	Kirill Korotaev <dev@...nvz.org>
Subject: Re: [PATCH] Virtual ethernet device (v2.1)

Hi.

On Wed, Jul 11, 2007 at 01:31:15PM +0400, Pavel Emelianov (xemul@...nvz.org) wrote:
> Veth stands for Virtual ETHernet. It is a simple tunnel driver
> that works at the link layer and looks like a pair of ethernet
> devices interconnected with each other.
> 
> Mainly it allows to communicate between network namespaces but
> it can be used as is as well.

I have minor comment about flags used in veth. It looks like you only
set LLTX bit, but check for other flags in the code, so why not to
include another performance features?

> +static void veth_setup(struct net_device *dev)
> +{
> +	ether_setup(dev);
> +
> +	dev->hard_start_xmit = veth_xmit;
> +	dev->get_stats = veth_get_stats;
> +	dev->open = veth_open;
> +	dev->stop = veth_close;
> +	dev->ethtool_ops = &veth_ethtool_ops;
> +	dev->features |= NETIF_F_LLTX;
> +	dev->init = veth_dev_init;
> +	dev->destructor = veth_dev_free;
> +	netif_carrier_off(dev);
> +}

Don't you want to include NETIF_F_SG, NETIF_F_NO_CSUM, NETIF_F_FRAGLIST,
NETIF_F_HIGHDMA and probably TSO fancy flags also to reduce cpu usage more?

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html