netdev - Re: [VLAN 02/04]: Fix MAC address handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070711.194158.131104856.davem@davemloft.net>
Date:	Wed, 11 Jul 2007 19:41:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	netdev@...r.kernel.org, greearb@...delatech.com, xemul@...nvz.org
Subject: Re: [VLAN 02/04]: Fix MAC address handling

From: Patrick McHardy <kaber@...sh.net>
Date: Wed, 11 Jul 2007 19:38:16 +0200 (MEST)

> [VLAN]: Fix MAC address handling
> 
> The VLAN MAC address handling is broken in multiple ways. When the address
> differs when setting it, the real device is put in promiscous mode twice,
> but never taken out again. Additionally it doesn't resync when the real
> device's address is changed and needlessly puts it in promiscous mode when
> the vlan device is still down.
> 
> Fix by moving address handling to vlan_dev_open/vlan_dev_stop and properly
> deal with address changes in the device notifier. Also switch to
> dev_unicast_add (which needs the exact same handling).
> 
> Since the set_mac_address handler is identical to the generic ethernet one
> with these changes, kill it and use ether_setup().
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>

Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html