netdev - Re: [PATCH] ps3: fix return value in the case of tx error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070712122712.06145fa3@freepuppy.rosehill.hemminger.net>
Date:	Thu, 12 Jul 2007 12:27:12 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Masakazu Mokuno <mokuno@...sony.co.jp>
Cc:	netdev@...r.kernel.org, cbe-oss-dev@...abs.org
Subject: Re: [PATCH] ps3: fix return value in the case of tx error

On Thu, 12 Jul 2007 15:59:26 +0900
Masakazu Mokuno <mokuno@...sony.co.jp> wrote:

> 	Hi
> 	
> This patch fixes the improper return value of the hard_start_xmit()
> handler of PS3 gelic network driver.
> 
> Signed-off-by: Masakazu Mokuno <mokuno@...sony.co.jp>
> ---
>  drivers/net/ps3_gelic_net.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/ps3_gelic_net.c
> +++ b/drivers/net/ps3_gelic_net.c
> @@ -803,7 +803,7 @@ kick:
>  error:
>  	card->netdev_stats.tx_dropped++;
>  	spin_unlock_irqrestore(&card->tx_dma_lock, flags);
> -	return NETDEV_TX_LOCKED;
> +	return NETDEV_TX_BUSY;
>  }
>  

Wrong again. In case of error the device should free the skb
and return NETDEV_TX_OK. When you return NETDEV_TX_BUSY the
assumption is that send will be requeued. Chances are that what
ever caused the skb not to usable will continue.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html