netdev - Re: [1/5][TG3]: Fix irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070711.194729.51420145.davem@davemloft.net>
Date:	Wed, 11 Jul 2007 19:47:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	mcarlson@...adcom.com, netdev@...r.kernel.org, gaagaan@...il.com
Subject: Re: [1/5][TG3]: Fix irq_sync race condition.

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 11 Jul 2007 16:31:45 -0700

> [TG3]: Fix irq_sync race condition.
> 
> Gagan Arneja <gaagaan@...il.com> pointed out that tg3_reset_task()
> could potentially race with another thread calling tg3_full_lock()
> such as the ethtool_set_xxx() functions.  This may trigger the
> BUG_ON() in tg3_irq_quiesce() or cause the irq_sync flag to be out-
> of-sync.
> 
> I think the easiest way to fix this is to get the tp->lock first
> before setting the irq_sync flag.  This is safe to do because the
> tp->lock is never grabbed by the irq handler.  This change will
> guarantee that the irq_sync flag updates will be serialized.  We also
> have to change one spot to call tg3_netif_start() (which clears the
> irq_sync flag) before releasing the tp->lock.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied, thanks Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html