netdev - Re: [PATCH] 7990 : Various fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070713104419.GA32178@ingate.macqel.be>
Date:	Fri, 13 Jul 2007 12:44:19 +0200
From:	Philippe De Muyter <phdm@...qel.be>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] 7990 : Various fixes and cleanups

On Tue, Jul 10, 2007 at 12:38:45PM -0400, Jeff Garzik wrote:
> Philippe De Muyter wrote:
> >This patch
> >- avoids 7990 blocking when no tx buffer is available,
> [...]
> >diff -r 6c0a10cc415a drivers/net/7990.c
> >--- a/drivers/net/7990.c	Thu Jul  5 16:10:16 2007 -0700
> >+++ b/drivers/net/7990.c	Fri Jul  6 11:27:20 2007 +0200
> [...]
> >@@ -541,9 +546,6 @@ int lance_start_xmit (struct sk_buff *sk
> >         static int outs;
> > 	unsigned long flags;
> > 
> >-        if (!TX_BUFFS_AVAIL)
> >-                return -1;
> >-
> > 	netif_stop_queue (dev);
> > 
> >         skblen = skb->len;
> 
> 
> NAK
> 
> It "avoids" by removing an overrun check in hard_start_xmit that should 
> not be removed.

Yup, sorry.

The real fact is still that this prevents/fixes lance/driver blocking on my
board, while the tx_timeout mechanism does not succeed at that, and that
on my board the driver is blocked when we return -1 on !TX_BUFFS_AVAIL.

I'll investigate why.

Philippe

PS : did you apply the rest of the patch ?

-- 
Philippe De Muyter  phdm at macqel dot be  Tel +32 27029044
Macq Electronique SA  rue de l'Aeronef 2  B-1140 Bruxelles  Fax +32 27029077
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html