[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <469782E7.1070302@bx.jp.nec.com>
Date: Fri, 13 Jul 2007 22:49:27 +0900
From: KII Keiichi <k-keiichi@...jp.nec.com>
To: Satyam Sharma <ssatyam@....iitk.ac.in>
CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Matt Mackall <mpm@...enic.com>,
Netdev <netdev@...r.kernel.org>,
Joel Becker <joel.becker@...cle.com>,
Stephen Hemminger <shemminger@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2 -mm 8/9] netconsole: Support multiple logging targets
Hi Satyam,
> From: Satyam Sharma <ssatyam@....iitk.ac.in>
>
> [8/9] netconsole: Support multiple logging targets
>
> This patch introduces support for multiple targets:
>
> Let's keep this out of CONFIG_NETCONSOLE_DYNAMIC as well -- this is useful
> even in the default case and (including the infrastructure introduced in
> previous patches) doesn't really add too many bytes to module text. All the
> complexity (and size) comes with the dynamic reconfigurability / userspace
> interface patch, and so it's plausible users may want to keep this enabled
> but that disabled (say to avoid a dep on CONFIG_CONFIGFS_FS too).
>
> Also update documentation to mention the use of ";" separator to specify
> multiple logging targets in the boot/module option string.
>
> Brief overview:
>
> We maintain a target_list (and corresponding lock). Get rid of the static
> "default_target" and introduce allocation and release functions for our
> netconsole_target objects (but keeping sure to preserve previous behaviour
> such as default values). During init_netconsole(), ";" is used as the
> separator to identify multiple target specifications in the boot/module
> option string. The target specifications are parsed and netpolls setup.
> During exit, the target_list is torn down and all items released.
>
> Signed-off-by: Satyam Sharma <ssatyam@....iitk.ac.in>
> Cc: Keiichi Kii <k-keiichi@...jp.nec.com>
>
Signed-off-by: Keiichi Kii <k-keiichi@...jp.nec.com>
Thanks
--
Keiichi KII
NEC Corporation OSS Platform Development Division
E-mail: k-keiichi@...jp.nec.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists