lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 14 Jul 2007 19:47:45 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	John Linville <linville@...driver.com>,
	Aurelien Jarno <aurelien@...el32.net>,
	linux-wireless@...r.kernel.org,
	Gary Zambrano <zambrano@...adcom.com>, netdev@...r.kernel.org
Subject: Re: [PATCH #2] Merge the Sonics Silicon Backplane subsystem

On Saturday 14 July 2007 19:26:05 Christoph Hellwig wrote:
> On Sat, Jul 14, 2007 at 07:18:20PM +0200, Michael Buesch wrote:
> > --- /dev/null
> > +++ b/drivers/ssb/Makefile
> > @@ -0,0 +1,11 @@
> > +ssb-builtin-drivers-y					+= driver_chipcommon.o
> > +ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
> > +ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
> > +
> > +ssb-hostsupport-$(CONFIG_SSB_PCIHOST)			+= pci.o pcihost_wrapper.o
> > +ssb-hostsupport-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
> > +
> > +obj-$(CONFIG_SSB) += ssb.o
> > +
> > +ssb-objs	:= main.o scan.o \
> > +		   $(ssb-hostsupport-y) $(ssb-builtin-drivers-y)
> 
> Whoa, this makefile is more than ugly :)
> 
> Please try something like:
> 
> # core
> ssb-y					+= main.o scan.o
> 
> # host support
> ssb-$(CONFIG_SSB_PCIHOST)		+= pci.o pcihost_wrapper.o
> ssb-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
> 
> # drivers
> ssb-y					+= driver_chipcommon.o
> ssb-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
> ssb-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
> 
> obj-$(CONFIG_SSB)			+= ssb.o
> 
> instead
> 
> 
> > +	default y
> 
> please don't add defauly y statements for random drivers.
> 

Thanks for your comments. I fixed that and will submit it
with the next round.

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists