netdev - Re: [PATCH] [IrDA] Fix IrDA build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070716151604.GB16474@uranus.ravnborg.org>
Date:	Mon, 16 Jul 2007 17:16:05 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Evgeniy Polyakov <johnpol@....mipt.ru>
Cc:	Samuel Ortiz <samuel.ortiz@...idboot.com>, davem@...emloft.net,
	eric.y.miao@...il.com, netdev@...r.kernel.org,
	irda-users@...ts.sourceforge.net, stable@...nel.org
Subject: Re: [PATCH] [IrDA] Fix IrDA build failure

On Mon, Jul 16, 2007 at 03:56:26PM +0400, Evgeniy Polyakov wrote:
> Hi Samuel.
> 
> On Mon, Jul 16, 2007 at 02:17:15PM +0300, Samuel Ortiz (samuel.ortiz@...idboot.com) wrote:
> > This is due to the irda_init fix recently added, where we call __exit
> > routines from an __init one. It is a build failure that I didn't catch
> > because it doesn't show up when building IrDA as a module. My apologies
> > for that.
> 
> What about having all of them __devinit/__devexit?

__devinit is used to say that this funtion is used for hotplug so place this
in section .init.text only if !HOTPLUG.

So with __devinit/__devexit we would see exactly the same in the !HOTPLUG
case but only make it harder to trigger since the normal build has
HOTPLUG enabled.

New version of modpost will btw. catch these kind of errors so also in the
x86 case we will be notified - but then only as a warning not as an error.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html