lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jul 2007 22:24:44 -0300 From: "Arnaldo Carvalho de Melo" <acme@...stprotocols.net> To: "Francois Romieu" <romieu@...zoreil.com> Cc: Mika.Lansirinne@...nesoft.com, "Jeff Garzik" <jeff@...zik.org>, netdev@...r.kernel.org Subject: Re: [PATCH 1/1] 8139cp: implement the missing dev->tx_timeout On 7/13/07, Francois Romieu <romieu@...zoreil.com> wrote: > Signed-off-by: Mika Lansirinne <mika.lansirinne@...nesoft.com> > --- > drivers/net/8139cp.c | 27 ++++++++++++++++++++++++--- > 1 files changed, 24 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c > index 807e699..e970e64 100644 > --- a/drivers/net/8139cp.c > +++ b/drivers/net/8139cp.c > @@ -26,7 +26,6 @@ > > TODO: > * Test Tx checksumming thoroughly > - * Implement dev->tx_timeout > > Low priority TODO: > * Complete reset on PciErr > @@ -1218,6 +1217,30 @@ static int cp_close (struct net_device *dev) > return 0; > } > > +static void cp_tx_timeout(struct net_device *dev) > +{ > + struct cp_private *cp = netdev_priv(dev); > + unsigned long flags; > + int rc; What is the point of this variable... > + > + printk(KERN_WARNING "%s: Transmit timeout, status %2x %4x %4x %4x\n", > + dev->name, cpr8(Cmd), cpr16(CpCmd), > + cpr16(IntrStatus), cpr16(IntrMask)); > + > + spin_lock_irqsave(&cp->lock, flags); > + > + cp_stop_hw(cp); > + cp_clean_rings(cp); > + rc = cp_init_rings(cp); ... if it is set and ... > + cp_start_hw(cp); > + > + netif_wake_queue(dev); > + > + spin_unlock_irqrestore(&cp->lock, flags); > + > + return; > +} ... never used? - Arnaldo - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists