lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jul 2007 07:28:50 -0700 From: Jeremy Fitzhardinge <jeremy@...p.org> To: Stephen Hemminger <shemminger@...ux-foundation.org> CC: Jeremy Fitzhardinge <jeremy@...source.com>, Linus Torvalds <torvalds@...ux-foundation.com>, Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.com>, lkml <linux-kernel@...r.kernel.org>, Xen-devel <xen-devel@...ts.xensource.com>, Chris Wright <chrisw@...s-sol.org>, Ian Pratt <ian.pratt@...source.com>, Christian Limpach <Christian.Limpach@...cam.ac.uk>, Jeff Garzik <jeff@...zik.org>, Christoph Hellwig <hch@...radead.org>, Rusty Russell <rusty@...tcorp.com.au>, Herbert Xu <herbert@...dor.apana.org.au>, Keir Fraser <Keir.Fraser@...cam.ac.uk>, netdev@...r.kernel.org Subject: Re: [patch 37/44] xen: add virtual network device driver Stephen Hemminger wrote: >> +struct netfront_info { >> + struct list_head list; >> + struct net_device *netdev; >> + >> + struct net_device_stats stats; >> > > There is now a net_device_stats element inside net_device on > 2.6.21 or later. > Ah, OK. Should I just do a s/stats/netdev->stats/? Is there a generic get_stats routine as well? >> + >> + struct xen_netif_tx_front_ring tx; >> + struct xen_netif_rx_front_ring rx; >> + >> + spinlock_t tx_lock; >> + spinlock_t rx_lock; >> > > It might be a performance advantage to reorder/align these > structure elements to put transmit hot elements together, and > put tx and rx on different cache lines? > Oh, right. I'd been meaning to look at that layout more closely. Thanks, J - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists