netdev - Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <469FAD4A.7090402@linux.vnet.ibm.com>
Date:	Thu, 19 Jul 2007 13:28:26 -0500
From:	Brian King <brking@...ux.vnet.ibm.com>
To:	Ragner Magalhaes <ragner.magalhaes@...t.org.br>
CC:	santil@...ux.vnet.ibm.com, rcjenn@...ux.vnet.ibm.com,
	netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable
 checksum offload

Ragner Magalhaes wrote:
> ext Brian King wrote:
>> Ragner Magalhaes wrote:
>>> here also, as above ...
>>>> +	if (data && (dev->features & NETIF_F_IP_CSUM))
>>>> +		return 0;
>>>> +	if (!data && !(dev->features & NETIF_F_IP_CSUM))
>>>> +		return 0;
>> This change would make the line > 80 columns, which I prefer to avoid.
>> Updated patch attached which addresses the first comment.
> I think would not be ugly to make.
> 
> 	if ((data && (dev->features & NETIF_F_IP_CSUM)) ||
> 		(!data && !(dev->features & NETIF_F_IP_CSUM)))
> 		return 0;

I find that less readable than what I currently have.

-Brian

-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html