netdev - Re: [TG3]: Fix msi issue with kexec/kdump.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Jul 2007 21:49:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	tina.yang@...cle.com, netdev@...r.kernel.org
Subject: Re: [TG3]: Fix msi issue with kexec/kdump.

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 18 Jul 2007 20:40:47 -0700

> [TG3]: Fix msi issue with kexec/kdump.
> 
> Tina Yang <tina.yang@...cle.com> discovered an MSI related problem
> when doing kdump.  The problem is that the kexec kernel is booted
> without going through system reset, and as a result, MSI may already
> be enabled when tg3_init_one() is called.  tg3_init_one() calls
> pci_save_state() which will save the stale MSI state.  Later on in
> tg3_open(), we call pci_enable_msi() to reconfigure MSI on the chip
> before we reset the chip.  After chip reset, we call
> pci_restore_state() which will put the stale MSI address/data back
> onto the chip.
> 
> This is no longer a problem in the latest kernel because
> pci_restore_state() has been changed to restore MSI state from
> internal data structures which will guarantee restoring the proper
> MSI state.
> 
> But I think we should still fix it.  Our save and restore sequence
> can still cause very subtle problems down the road.  The fix is to
> have our own functions save and restore precisely what we need.  We
> also change it to save and restore state inside tg3_chip_reset() in a
> more straight forward way.
> 
> Thanks to Tina for helping to test and debug the problem.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Looks good, applied.

For good measure, I bumped the driver version and release date.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html