netdev - Re: ~3 hours old git tree: Virtual device lo asks to queue packet!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jul 2007 12:11:10 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
CC:	Arkadiusz Miskiewicz <arekm@...en.pl>, netdev@...r.kernel.org
Subject: Re: ~3 hours old git tree: Virtual device lo asks to queue packet!

Patrick McHardy wrote:
> Arkadiusz Miskiewicz wrote:
> 
>>>>CONFIG_NETDEVICES_MULTIQUEUE=y
>>>
>>>Does it go away if you disable this option?
>>
>>
>>Yes, it goes away after disabling this.
> 
> 
> I don't see a bug in the code itself, maybe the queue_mapping points
> to an invalid subqueue. Could you please try this patch and post the
> output?

OK I see what the problem is. The loopback device is statically
allocated, so it doesn't have any room for the subqueues reserved.

The easiest fix would be to use egress_subqueue[1] in struct
net_device, but I think that may cause warnings with newer gccs
when using a constant index that is > 0. OTOH using constant
indices doesn't seem to make much sense for the subqueue array.

Arkadiusz, does this patch fix the problem?

View attachment "x" of type "text/plain" (1329 bytes)