lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 20 Jul 2007 18:22:42 -0700
From:	Divy Le Ray <divy@...lsio.com>
To:	Denis Cheng <crquan@...il.com>
CC:	linux-bugs@...lsio.com, Andrew Morton <akpm@...ux-foundation.org>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	cr_quan@....com
Subject: Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization

Denis Cheng wrote:
> Cc: linux-bugs@...lsio.com
> Signed-off-by: Denis Cheng <crquan@...il.com>
>   
Acked-by: Divy Le Ray <divy@...lsio.com>

> ---
>  drivers/net/cxgb3/cxgb3_main.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c
> index 6fd1e52..45711f9 100644
> --- a/drivers/net/cxgb3/cxgb3_main.c
> +++ b/drivers/net/cxgb3/cxgb3_main.c
> @@ -754,7 +754,7 @@ static int upgrade_fw(struct adapter *adap)
>   */
>  static int cxgb_up(struct adapter *adap)
>  {
> -	int err = 0;
> +	int err;
>  
>  	if (!(adap->flags & FULL_INIT_DONE)) {
>  		err = t3_check_fw_version(adap);
> @@ -861,7 +861,7 @@ static int offload_open(struct net_device *dev)
>  	struct adapter *adapter = dev->priv;
>  	struct t3cdev *tdev = T3CDEV(dev);
>  	int adap_up = adapter->open_device_map & PORT_MASK;
> -	int err = 0;
> +	int err;
>  
>  	if (test_and_set_bit(OFFLOAD_DEVMAP_BIT, &adapter->open_device_map))
>  		return 0;
> @@ -1502,7 +1502,7 @@ static int set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom,
>  		      u8 * data)
>  {
>  	u8 *buf;
> -	int err = 0;
> +	int err;
>  	u32 aligned_offset, aligned_len, *p;
>  	struct adapter *adapter = dev->priv;
>  
>   

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ