netdev - Re: [PATCH]: Resurrect napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A19DBF.6030902@trash.net>
Date:	Sat, 21 Jul 2007 07:46:39 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	rusty@...tcorp.com.au, jgarzik@...ox.com
Subject: Re: [PATCH]: Resurrect napi_poll patch.

David Miller wrote:
[ huge patch, not looked at it :) ]

> One area for discussion is what to do about rtnetlink, it allows
> setting the dev->napi.weight, but we need to extend it so it can
> do something sane in multi-napi-per-netdev situations.

I believe the compat attribute should work fine. One thing thing
that is not explicitly supported as datatype, but works fine, is
lists of attributes (using nla_for_each_attr), which looks like a
good match for this case. But I think its questionable whether we
should put any effort in NAPI rtnetlink support. It seems to driver
specific for rtnetlink to me, and I'm not aware of any user of this.
Ethtool might have its own compatibility issues, I'm not sure, but
I don't think it would hurt to simply remove it from rtnetlink.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html