netdev - Re: [PATCH]: Resurrect napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1185004811.6344.37.camel@localhost.localdomain>
Date:	Sat, 21 Jul 2007 18:00:11 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	jgarzik@...ox.com
Subject: Re: [PATCH]: Resurrect napi_poll patch.

On Sat, 2007-07-21 at 00:42 -0700, David Miller wrote:
> From: Rusty Russell <rusty@...tcorp.com.au>
> Date: Sat, 21 Jul 2007 17:14:31 +1000
> 
> > 	This looks good!  It might be nice though to go further and remove the
> > internal napi_struct.  It's kind of a wart for multi-queue drivers which
> > are going to have their own array (or whatever).
> 
> I guess you're suggesting to pass in a "void *" cookie instead of the
> napi_struct?  You'd need to pass in a slot number or similar as well
> with that kind of idea, and then it starts to push the limits or
> worthwhileness.

No, I was just thinking that drivers will put the napi_struct in their
driver-specific struct (eg. struct e1000_adapter *adapter =
container_of(container_of(napi, struct e1000_adapter, napi);).  

Multi-queue drivers will have no use for a napi_struct in net_device,
right?  They'll need some wrapper "my_queue" structure containing the
napi_struct anyway.

Hope that clarifies,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html