netdev - Re: [PATCH]: Resurrect napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1185059423.6344.53.camel@localhost.localdomain>
Date:	Sun, 22 Jul 2007 09:10:23 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	jgarzik@...ox.com
Subject: Re: [PATCH]: Resurrect napi_poll patch.

On Sat, 2007-07-21 at 11:54 -0700, David Miller wrote:
> From: Rusty Russell <rusty@...tcorp.com.au>
> Date: Sat, 21 Jul 2007 18:00:11 +1000
> 
> > No, I was just thinking that drivers will put the napi_struct in their
> > driver-specific struct (eg. struct e1000_adapter *adapter =
> > container_of(container_of(napi, struct e1000_adapter, napi);).  
> 
> That works.
> 
> > Multi-queue drivers will have no use for a napi_struct in net_device,
> > right?  They'll need some wrapper "my_queue" structure containing the
> > napi_struct anyway.
> 
> Sure, we can eliminate the napi_struct in struct net_device
> eventually.
> 
> But then again, like the statistics, if it's convenient to
> just use the in-net_device one then why not :)

Because *every* single driver can use the in-net_device stats.

In five years' time, the "napi_struct for simple drivers" in net_device
will look confusing.  Since your change touches all NAPI drivers anyway,
it'd be nice to go straight to "everyone allocates their own NAPI
struct" in one jump.

Cheers,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html