lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 22 Jul 2007 12:41:36 +0300
From:	"Michael S. Tsirkin" <>
To:	Krishna Kumar <>
Subject: Re: [PATCH 11/12 -Rev2] IPoIB xmit API addition

> +	/*
> +	 * Handle skbs completion from tx_tail to wr_id. It is possible to
> +	 * handle WC's from earlier post_sends (possible multiple) in this
> +	 * iteration as we move from tx_tail to wr_id, since if the last
> +	 * WR (which is the one which had a completion request) failed to be
> +	 * sent for any of those earlier request(s), no completion
> +	 * notification is generated for successful WR's of those earlier
> +	 * request(s).
> +	 */

AFAIK a signalled WR will always generate a completion.
What am I missing?

> +			/*
> +			 * Better error handling can be done here, like free
> +			 * all untried skbs if err == -ENOMEM. However at this
> +			 * time, we re-try all the skbs, all of which will
> +			 * likely fail anyway (unless device finished sending
> +			 * some out in the meantime). This is not a regression
> +			 * since the earlier code is not doing this either.
> +			 */

Are you retrying posting skbs? Why is this a good idea?
AFAIK, earlier code did not retry posting WRs at all.
The comment seems to imply that post send fails as a result of SQ overflow -
do you see SQ overflow errors in your testing?
AFAIK, IPoIB should never overflow the SQ.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists