lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Jul 2007 19:10:05 -0700 (PDT) From: David Miller <davem@...emloft.net> To: viro@....linux.org.uk Cc: netdev@...r.kernel.org Subject: Re: [PATCH] endianness bug in ip6_tunnel From: Al Viro <viro@....linux.org.uk> Date: Sat, 21 Jul 2007 09:12:31 +0100 > IPV6_TCLASS_MASK is net-endian; what happens here is that we take > a value and shove it into bits 20--27 of net-endian 32bit word. > IOW, it's misannotated (it's really htonl, not ntohl) *and* the > mask should be applied after conversion to net-endian, not before it. > The former is harmless, the latter gives the wrong value on little-endian; > As the matter of fact, on l-e it gives 0 - IPV6_TCLASS_MASK will be > htonl(0x0ff00000), i.e. on little-endian we have (something << 20) & 0xff0... > > Signed-off-by: Al Viro <viro@...iv.linux.org.uk> Applied, thanks Al. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists