netdev - Re: [PATCH 2/4] Add new timeval_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A57CF3.6040505@linux.vnet.ibm.com>
Date:	Tue, 24 Jul 2007 09:45:47 +0530
From:	Varun Chandramohan <varunc@...ux.vnet.ibm.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	netdev@...r.kernel.org, sri@...ibm.com, dlstevens@...ibm.com,
	varuncha@...ibm.com
Subject: Re: [PATCH 2/4] Add new timeval_to_sec function

Patrick McHardy wrote:
> Varun Chandramohan wrote:
>   
>>  /**
>> + * timeval_to_sec - Convert timeval to seconds
>> + * @tv:         pointer to the timeval variable to be converted
>> + *
>> + * Returns the seconds representation of timeval parameter.
>> + */
>> +static inline time_t timeval_to_sec(const struct timeval *tv)
>> +{
>> +	return (tv->tv_sec + (tv->tv_usec + 500000)/1000000);
>> +}
>>     
>
>
> I don't think you should round down timeout values.
>   
Can you elaborate on that? As per the RFC of MIB ,we need only seconds
granularity. Taking that as the case i dont understand why round down
should not be done?

Regards,
Varun
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html