netdev - Re: [GENETLINK]: Fix race in genl_unregister_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Jul 2007 12:14:28 -0400
From:	Brian Haley <brian.haley@...com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	davem@...emloft.net, johannes@...solutions.net,
	netdev@...r.kernel.org
Subject: Re: [GENETLINK]: Fix race in genl_unregister_mc_groups()

Thomas Graf wrote:
> @@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
>  void genl_unregister_mc_group(struct genl_family *family,
>  			      struct genl_multicast_group *grp)
>  {
> -	BUG_ON(grp->family != family);
>  	genl_lock();
> -	netlink_clear_multicast_users(genl_sock, grp->id);
> -	clear_bit(grp->id, mc_groups);
> -	list_del(&grp->list);
> -	genl_ctrl_event(CTRL_CMD_DELMCAST_GRP, grp);
> -	grp->id = 0;
> -	grp->family = NULL;
> +	genl_unregister_mc_group(family, grp);
>  	genl_unlock();
>  }

Shouldn't this be __genl_unregister_mc_group(family, grp) ?

-Brian
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html