netdev - Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A65FEF.2030303@garzik.org>
Date:	Tue, 24 Jul 2007 16:24:15 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Micah Gruber <micah.gruber@...il.com>
CC:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in
 mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c

Micah Gruber wrote:
> This patch fixes a potential null dereference bug where we dereference 
> DEV before a null check. This patch simply moves the dereferencing after 
> the null check.
> 
> Signed-off-by: Micah Gruber <micah.gruber@...il.com>
> 
> ---
> 
> --- a/drivers/net/pcmcia/nmclan_cs.c    +++ 
> b/drivers/net/pcmcia/nmclan_cs.c    @@ -996,7 +996,7 @@

PLEASE PLEASE PLEASE fix your mailer.

None of your patches are apply-able via script or patch(1), which is how 
all Linux maintainers apply patches.

If you want to contribute to the kernel, you -must- figure out how to 
send patches via email.

Linux kernel development is done almost exclusively through email, so it 
is very important to get the details right.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html