netdev - Re: Tc filtering: broken 802

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A7D892.3020505@trash.net>
Date:	Thu, 26 Jul 2007 01:11:14 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
CC:	netdev@...r.kernel.org
Subject: Re: Tc filtering: broken 802_3 classifier?

Waskiewicz Jr, Peter P wrote:
>>Waskiewicz Jr, Peter P wrote:
>>
>>I'm not sure what you're expecting. skb->protocol is usually not set
>>to ETH_P_802_3, which is why the filter is not matching.
> 
> 
> I understand that.  I had two issues, which you cleared up one by
> reminding me that the protocol matches on skb->protocol before it tries
> to run the ->classify() routine.  The other issue I am seeing is with 8
> bands, an 802_3 filter is affecting classification of IP traffic.  For
> example, I have an 802_3 filter to look for dst MAC address, but an ssh
> packet, which without any filters should go into flowid 1:3 on my
> system, is getting pushed into flowid 1:1.  I remove the 802_3 filter,
> and ssh traffic starts going back into 1:3.  No other filters on the
> system.  That's the main issue I'm seeing, so I'll keep investigating to
> see what's going on.

In case of prio, if your manually installed filters don't match, it will
fall back to the skb->priority based classification, which is based
on tos and is probably responsible for what you're seeing. Feel free to
investigate, but you could save us all some time by simply posting what
you're doing, what you're expecting and what is actually happening,
there's probably a good explanation.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html