netdev - Re: [PATCH 2/4 -rev1] Add new timeval_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46A837FE.5060900@cosmosbay.com>
Date:	Thu, 26 Jul 2007 07:58:22 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Varun Chandramohan <varunc@...ux.vnet.ibm.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org, kaber@...sh.net,
	socketcan@...tkopp.net, shemminger@...ux-foundation.org,
	krkumar2@...ibm.com
Subject: Re: [PATCH 2/4 -rev1] Add new timeval_to_sec function

Varun Chandramohan a écrit :
> A new function for converting timeval to time_t is added in time.h. Its a common function used in different
> places. The timeout is now rounded up as per the suggestion.
> 
> Signed-off-by: Varun Chandramohan <varunc@...ux.vnet.ibm.com>
> ---
>  include/linux/time.h |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/time.h b/include/linux/time.h
> index dda9be6..908329a 100644
> --- a/include/linux/time.h
> +++ b/include/linux/time.h
> @@ -147,6 +147,17 @@ static inline s64 timeval_to_ns(const st
>  }
>  
>  /**
> + * timeval_to_sec - Convert timeval to seconds
> + * @tv:         pointer to the timeval variable to be converted
> + *
> + * Returns the seconds representation of timeval parameter.
> + */
> +static inline time_t timeval_to_sec(const struct timeval *tv)
> +{
> +	return (tv->tv_sec + (tv->tv_usec + 999999)/1000000);
> +}
> +
> +/**

return tv->tv_sec + (tv->tv_usec ? 1 : 0);

is much faster

Also, the comment is not accurate, as it doesnt mention the roundup at all.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html