netdev - Re: [PATCH RFC]: napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1551EAE59135BE47B544934E30FC4FC002AAB9F6@nt-irva-0751.brcm.ad.broadcom.com>
Date:	Wed, 25 Jul 2007 23:33:03 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"David Miller" <davem@...emloft.net>, netdev@...r.kernel.org
cc:	shemminger@...ux-foundation.org, jgarzik@...ox.com,
	hadi@...erus.ca, rusty@...tcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4

David Miller wrote:

>  	/* run TX completion thread */
>  	if (sblk->idx[0].tx_consumer != tp->tx_cons) {
> -		tg3_tx(tp);
> +		netif_tx_lock(netdev);
> +		__tg3_tx(tp);
> +		netif_tx_unlock(netdev);
>

This will lead to more and longer lock contentions between
->hard_start_xmit() and ->poll() in the normal fast path.  Why
do we need to widen the scope of netif_tx_lock() in this case?

By not taking the netif_tx_lock() during tx completions until
the last moment and only when necessary improves the performance
substantially.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html