netdev - Re: [PATCH RFC]: napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070725.234342.63127611.davem@davemloft.net>
Date:	Wed, 25 Jul 2007 23:43:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	jgarzik@...ox.com, hadi@...erus.ca, rusty@...tcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 25 Jul 2007 23:39:18 -0700

> David Miller wrote:
> 
> > As a result there is no more messing around with fake NAPI polls and
> > all that other crap, instead ->poll_controller() merely has to try to
> > process TX queue acks to free up space and wake up the transmit
> > queue(s) of the device.
> > 
> 
> I think we also need to take care of link change interrupts as well.

Since netpoll is best-effort, we can elide that I think.
The more requirements you put into this ->poll_controller()
handler, the more complicated it gets.

Furthermore, this should work out.  If the link is down, the top level
poll loop will timeout waiting for the TX queue to open up, which will
kick the netpoll processing into a work queue, the link handling will
be allowed to occur meanwhile.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html