netdev - Re: [PATCH 2/6] [NET]: Take dev_base_lock when moving device name hash list entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070730.163608.35468199.davem@davemloft.net>
Date:	Mon, 30 Jul 2007 16:36:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH 2/6] [NET]: Take dev_base_lock when moving device name
 hash list entry

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 26 Jul 2007 17:09:30 +0800

> [NET]: Take dev_base_lock when moving device name hash list entry
> 
> When we added name-based hashing the dev_base_lock was designated as the
> lock to take when changing the name hash list.  Unfortunately, because
> it was a preexisting lock that just happened to be taken in the right
> spots we neglected to take it in dev_change_name.
> 
> The race can affect calles of __dev_get_by_name that do so without taking
> the RTNL.  They may end up walking down the wrong hash chain and end up
> missing the device that they're looking for.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Good catch, applied, thanks Herbert.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html