netdev - Re: [PATCH RFC]: napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jul 2007 17:25:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org,
	jgarzik@...ox.com, hadi@...erus.ca, rusty@...tcorp.com.au
Subject: Re: [PATCH RFC]: napi_struct V4

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 26 Jul 2007 14:38:09 -0700

> If the driver wants a simple solution, it can do what you did in the
> patch:  wrap the tx cleanup code with netif_tx_lock() and
> netif_tx_unlock().
> 
> If a NAPI driver wants to be more clever, it can do something such as
> this in tg3's poll_controller:
> 
> if (netif_rx_schedule_prep(dev, &tp->napi)) {
> 	tg3_tx(tp);
> 	netif_poll_enable(tp->napi);
> }

Thanks Michael, that's a good suggestion and would work.

In thinking about this some more over the weekend I've decided
that my plan to rip out RX support from netpoll is a bit too
ambitious.

Therefore, for the time being, I'm going to add a special driver
function for netpoll that will allow it to ask the driver to invoke
->poll() over all the NAPI structs assosciated with the netdev.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html