netdev - Re: [PATCH] pktgen - define and use pktgen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1185925686.14777.22.camel@localhost>
Date:	Tue, 31 Jul 2007 16:48:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	Robert.Olsson@...a.slu.se, netdev@...r.kernel.org
Subject: Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

On Mon, 2007-07-30 at 16:05 -0700, David Miller wrote:
> I still don't know about this patch.  Instead of the simple
> transformation:
> 
> -	printk(foo);
> +	printk(KERN_INFO foo);
> 
> we get this new macro, and the lines changes to use that macro.

Actually, I agree.

Many local macros could be eliminated that define
printk(<level> prefix)

I'd like to see macros added to kernel.h for:

	pr_err
	pr_notice
	pr_warn
	pr_alert
	pr_crit
	pr_emerge

and convert tree-wide all the single-line

	printk(KERN_<level> [prefix] fmt "\n", args...)

calls to the equivalent pr_<level> calls.

That would leave the multi-line printk(<level>...) calls
to be sorted out so these messages might no longer be
interleaved by multiple cpus/threads.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html