netdev - Re: RFC: on [ab]use of skb->cb by VLAN code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070730.183337.27784025.davem@davemloft.net>
Date:	Mon, 30 Jul 2007 18:33:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hadi@...erus.ca
Cc:	greearb@...delatech.com, kaber@...sh.net, netdev@...r.kernel.org,
	mcarlson@...adcom.com
Subject: Re: RFC: on [ab]use of skb->cb by VLAN code

From: jamal <hadi@...erus.ca>
Date: Mon, 30 Jul 2007 20:59:16 -0400

> This seems like a bad use since there can be a lot of things between 
> a real hardware driver and something that sets a vlan tag (qdiscs come
> to mind).

I understand the concern, but how much qdisc stuff can possibly
happen between those two ->hard_start_xmit() calls and do we
want to support that in any way anyways?

The only alternative I see is to add more things to struct sk_buff
and that's usually very unpopular :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html