netdev - Re: RFC: on [ab]use of skb->cb by VLAN code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46AEBADB.7030007@candelatech.com>
Date:	Mon, 30 Jul 2007 21:30:19 -0700
From:	Ben Greear <greearb@...delatech.com>
To:	David Miller <davem@...emloft.net>
CC:	hadi@...erus.ca, kaber@...sh.net, netdev@...r.kernel.org,
	mcarlson@...adcom.com
Subject: Re: RFC: on [ab]use of skb->cb by VLAN code

David Miller wrote:
> From: jamal <hadi@...erus.ca>
> Date: Mon, 30 Jul 2007 22:02:04 -0400
>
>   
>> I came across the issue because i used cb in batching to store transient
>> state which is used between qdisc dequeueing and hardware enqueueing
>> (looked and smelled legit to me).
>>     
>
> Right, dequeue->device should be OK and doesn't work because of
> the VLAN issue.
>   

So, shall we add a new field to the skb in order to get the info out of cb?

Looks like a single 32-bit field would be sufficient.

Thanks,
Ben


-- 
Ben Greear <greearb@...delatech.com> 
Candela Technologies Inc  http://www.candelatech.com


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html