netdev - Re: [PATCH]: Fix sk_buff page offsets and lengths.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070731102050.GB30330@2ka.mipt.ru>
Date:	Tue, 31 Jul 2007 14:20:51 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, sfr@...b.auug.org.au,
	shemminger@...ux-foundation.org
Subject: Re: [PATCH]: Fix sk_buff page offsets and lengths.

On Mon, Jul 30, 2007 at 06:50:28PM -0700, David Miller (davem@...emloft.net) wrote:
> 
> Stephen Rothwell pointed out to me that the skb_frag_struct
> is broken on platforms using 64K or larger page sizes, it
> even generates warnings when (for example) the myri10ge driver
> tries to assign PAGE_SIZE into frag->size.
> 
> I've thus increased page offset and size to __u32 in the patch below.

Maybe wrap it into 
#if PAGE_OFFSET > 12
#endif

or something like that?

I'm not sure actually why drivers would want to have list of 64k pages,
instead driver could call give_me_pages(size) instead of alloc_pages 
and per-arch allocator would return one page or set of pages. This is a
handwaving for now...

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html