netdev - Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Aug 2007 21:13:45 +0300
From:	"Eliezer Tamir" <eliezert@...adcom.com>
To:	"Jeff Garzik" <jeff@...zik.org>,
	"Roland Dreier" <rdreier@...co.com>
cc:	"Michael Buesch" <mb@...sch.de>,
	"Michael Chan" <mchan@...adcom.com>, davem@...emloft.net,
	netdev@...r.kernel.org, lusinsky@...adcom.com, eilong@...adcom.com
Subject: Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.

Jeff, Roland,

Thanks for taking a look.

Jeff Garzik wrote:
> Roland Dreier wrote:
>>  > > +    { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5710,
>>  > > +        PCI_ANY_ID, PCI_ANY_ID, 0, 0, BCM5710 },
>>
>> FWIW, this could be neater as
>>
>>     { PCI_VDEVICE(BROADCOM, PCI_DEVICE_ID_NX2_5710), BCM5710 }

OK

> Yes.  And additionally, I prefer (but not require) that people directly 
> use a hexidecimal constant in the PCI ID table for device ID, if that is 
> the only place in the entire codebase referring to that PCI device ID.
> 
> Using a named constant for a single-use PCI device ID merely aggrevates 
> include/linux/pci_ids.h patching headache for what is ultimately an 
> arbitrary number [usually] picked out of thin air by the hw vendor.
> 
>     Jeff

For now it is the only place used, but this will change very soon, once 
we have several flavors of the chip out. then we will have to handle 
each in a slightly different manner.

Eliezer



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html