netdev - Re: [patch 4/5][RFC] Implement devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070803092054.GM13674@htj.dyndns.org>
Date:	Fri, 3 Aug 2007 18:20:54 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Brandon Philips <brandon@...e.de>
Cc:	netdev@...r.kernel.org, teheo@...e.de,
	Brandon Philips <bphilips@...e.de>
Subject: Re: [patch 4/5][RFC] Implement devm_kcalloc

On Thu, Aug 02, 2007 at 03:45:45PM -0700, Brandon Philips wrote:
>  /**
> + * devm_kcalloc - resource-managed kcalloc
> + * @dev: Device to allocate memory for
> + * @n: number of elements.
> + * @size: element size.
> + * @flags: the type of memory to allocate.
> + */
> +inline void * devm_kcalloc(struct device * dev, size_t n, size_t size,
> +			   gfp_t flags)
> +{
> +        if (n != 0 && size > ULONG_MAX / n)
> +                return NULL;
> +        return devm_kzalloc(dev, n * size, flags);
> +}
> +EXPORT_SYMBOL_GPL(devm_kcalloc);

Please drop inline.  It's meaningless.

Other than that, Acked-by: Tejun Heo <htejun@...il.com>

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html