netdev - Re: [PATCH] drivers/net/wireless/wl3501

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070807001155.GA3285@tuxdriver.com>
Date:	Mon, 6 Aug 2007 20:11:55 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	acme@...stprotocols.net, Jeff Garzik <jgarzik@...ox.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH] drivers/net/wireless/wl3501_cs.c: remove redundant
	memset

Please send wireless patches to linux-wireless@...r.kernel.org,
and CC me.

Thanks!

John

On Tue, Aug 07, 2007 at 12:50:22AM +0200, Mariusz Kozlowski wrote:
> Hello,
> 
> 	This memset() looks superfluous.
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>
> 
>  drivers/net/wireless/wl3501_cs.c | 58885 -> 58858 (-27 bytes)
>  drivers/net/wireless/wl3501_cs.o | 200252 -> 200000 (-252 bytes)
> 
>  drivers/net/wireless/wl3501_cs.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-2.6.23-rc1-mm2-a/drivers/net/wireless/wl3501_cs.c	2007-08-01 08:43:46.000000000 +0200
> +++ linux-2.6.23-rc1-mm2-b/drivers/net/wireless/wl3501_cs.c	2007-08-07 00:34:36.000000000 +0200
> @@ -1841,7 +1841,6 @@ static int wl3501_get_encode(struct net_
>  	tocopy = min_t(u8, len_keys, wrqu->encoding.length);
>  	tocopy = min_t(u8, tocopy, 100);
>  	wrqu->encoding.length = tocopy;
> -	memset(extra, 0, tocopy);
>  	memcpy(extra, keys, tocopy);
>  out:
>  	return rc;
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
John W. Linville
linville@...driver.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html