netdev - Re: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46B80522.70202@linux.intel.com>
Date:	Mon, 06 Aug 2007 22:37:38 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
CC:	Andi Kleen <andi@...stfloor.org>, Jeff Garzik <jgarzik@...ox.com>,
	NetDev <netdev@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	"Ronciak, John" <john.ronciak@...el.com>
Subject: Re: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9
 devices only)

Kok, Auke wrote:
> Andi Kleen wrote:
>> "Kok, Auke" <auke-jan.h.kok@...el.com> writes:
>>
>>> All,
>>>
>>> Another update on e1000e. Many thanks to Jeff for helping out and
>>> getting this going forward. The driver is unfortunately still too
>>> large to post, so please use the URL's below to review:
>>
>> Just some things I noticed; no comprehensive review
> 
> thanks, quick reply to one of the issues below, others I'll take into 
> account and look into deeper.
> 
> 
>> +       mod_timer(&adapter->blink_timer, jiffies + E1000_ID_INTERVAL);
>> Should use round_jiffies to avoid wakeups
> 
> actually, not here - we don't want the led to blink unreliably. If the 
> timer gets stalled beyond 1/2 a second and is irregular, you'll never be 
> able to identify the proper adapter port in you data center.
> 
> remember, this is only used once the user invokes 'ethtool -p'

round_jiffies is regular, except for the first time..

(it's a whole-second only though)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html