netdev - Re: [PATCH 2/14] nes: device structures and defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2007 09:18:31 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Michael Buesch <mb@...sch.de>
Cc:	Andi Kleen <andi@...stfloor.org>, Jeff Garzik <jeff@...zik.org>,
	ggrundstrom@...effect.com, ewg@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/14] nes: device structures and defines

 > But there are indeed a few cases that look wrong.

yes...

 > arch/x86_64/kernel/pci-calgary.c:       writel(cpu_to_be32(val), target);

eg this almost certainly wants to be

	writel(swab32(val), target);

or something equivalent like

	__raw_writel(cpu_to_be32(val), target);
	/* plus some suffficent memory ordering */

 - R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html