netdev - Re: [ewg] [PATCH 11/14] nes: OpenFabrics kernel verbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Aug 2007 13:10:14 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	ggrundstrom@...effect.com
Cc:	netdev@...r.kernel.org, ewg@...ts.openfabrics.org
Subject: Re: [ewg] [PATCH 11/14] nes: OpenFabrics kernel verbs

 > +static struct ib_mw *nes_alloc_mw(struct ib_pd *ibpd) {

 > +	get_random_bytes(&next_stag_index, sizeof(next_stag_index));

Could this use up a lot of entropy?  Is random32() sufficient?

 > +	stag_key = (u8)next_stag_index;

I don't think this cast is needed.

 > +	if (ret) {
 > +		return (ERR_PTR(ret));
 > +	}

Don't need braces for one-line blocks.

 > +	if (NULL == cqp_request) {

It's more idiomatic to write "if (!cqp_request) {"
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html