netdev - Re: [PATCH 3/14] nes: connection manager routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada1wecobi1.fsf@cisco.com>
Date:	Thu, 09 Aug 2007 10:37:10 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	ggrundstrom@...effect.com, ewg@...ts.openfabrics.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 3/14] nes: connection manager routines

 > > +atomic_t cm_connects;
 > > +atomic_t cm_accepts;
 > > +atomic_t cm_disconnects;
 > > +atomic_t cm_closes;
 > > +atomic_t cm_connecteds;
 > > +atomic_t cm_connect_reqs;
 > > +atomic_t cm_rejects;
 > 
 > do you really want to take the hit of a LOCK prefix each time you
 > increment a stat???

I think these are once-per-connection things, so the overhead is not
that bad.  On the other hand there's probably another lock you have to
take anyway so maybe you can just define that these are protected by
some lock you take anyway.

Also, these names seem kind of generic to be global -- a nes_ prefix
is probably appropriate.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html