lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Aug 2007 11:56:12 +0530 From: Krishna Kumar2 <krkumar2@...ibm.com> To: David Miller <davem@...emloft.net> Cc: gaagaan@...il.com, general@...ts.openfabrics.org, hadi@...erus.ca, herbert@...dor.apana.org.au, jagana@...ibm.com, jeff@...zik.org, johnpol@....mipt.ru, kaber@...sh.net, kumarkr@...ux.ibm.com, mcarlson@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org, peter.p.waskiewicz.jr@...el.com, rdreier@...co.com, rick.jones2@...com, Robert.Olsson@...a.slu.se, shemminger@...ux-foundation.org, sri@...ibm.com, tgraf@...g.ch, xma@...ibm.com Subject: Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB David Miller <davem@...emloft.net> wrote on 08/09/2007 09:57:27 AM: > > > Patrick had suggested calling dev_hard_start_xmit() instead of > > conditionally calling the new API and to remove the new API > > entirely. The driver determines whether batching is required or > > not depending on (skb==NULL) or not. Would that approach be fine > > with this "single interface" goal ? > > It is a valid posibility. > > Note that this is similar to how we handle TSO, the driver > sets the feature bit and in its ->hard_start_xmit() it checks > the SKB for the given offload property. Great, I will try to get rid of two paths entirely, and see how to re-arrange the code cleanly. thanks, - KK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists