netdev - Re: [PATCH] SSB PCI core driver fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708090227.06510.mb@bu3sch.de>
Date:	Thu, 9 Aug 2007 02:27:06 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Aurelien Jarno <aurelien@...el32.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] SSB PCI core driver fixes

On Thursday 09 August 2007, Aurelien Jarno wrote:
>  - Add some delay between the configuration of the PCI controller 
>    and its registration.

Why? It is _huge_ and people won't like it ;)
At least add a comment why this is needed.

> @@ -340,6 +345,7 @@
>  	 * The following needs change, if we want to port hostmode
>  	 * to non-MIPS platform. */
>  	set_io_port_base((unsigned long)ioremap_nocache(SSB_PCI_MEM, 0x04000000));
> +	mdelay(300);
>  	register_pci_controller(&ssb_pcicore_controller);
>  }
> 


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html