netdev - Re: [PATCH 6/14] nes: hardware init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070809115644.479a872c@oldman.hamilton.local>
Date:	Thu, 9 Aug 2007 11:56:44 +0100
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Glenn Grundstrom" <ggrundstrom@...Effect.com>
Cc:	"Jeff Garzik" <jeff@...zik.org>, <rdreier@...co.com>,
	<ewg@...ts.openfabrics.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 6/14] nes: hardware init

More comments

>---
>diff -Nurp NULL ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.c
>--- NULL	1969-12-31 18:00:00.000000000 -0600
>+++ ofa_kernel-1.2/drivers/infiniband/hw/nes/nes_hw.c	2007-08-06 20:09:04.000000000 -0500
>+
>+#include "nes.h"
>+u32 crit_err_count = 0;

Possible global namespace conflict.  You should make sure all global
symbols start with something specfic to driver like "nes_".

>+#include "nes_cm.h"
>+
>+
>+#ifdef NES_DEBUG
>+static unsigned char *nes_iwarp_state_str[] = {

Why use unsigned char? This should be "static const char *"
Maybe use gcc array initilaizers.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html